New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP112: Update document to match implementation #248
Conversation
b71b795
to
520318a
Compare
Not good, remove:
This is not true, if one of those conditions are true, then script fail. If none of them are true, then processing will continue as defined in this BIP. The only condition this is considered a NOP is if SCRIPT_VERIFY_CHECKSEQUENCEVERIFY flag is disabled. Which is not worth mentioning in the BIP. |
@NicolasDorier This is the same language used in BIP65. If the script does not fail, script execution continues as if a NOP had been executed. |
Ok I see. Well, it is strange to say "executed as a NOP" as opposed to "the stack is not affected by this operation". It does not stop me from understanding just finding it weird. Not a stopper though, if nobody complains let's keep it like that. |
Taken from 20/11/15 version of deployable lightning
ACK. I would replace "Otherwise, script execution will continue as if a NOP had been executed." with "OP_CSV has no effect on the stack". But not worth complaining too much about if I am the only one to think so. |
BIP112: Update document to match implementation
For bitcoin/bitcoin#6564