Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds multisig support #253

Closed
wants to merge 2 commits into from
Closed

Adds multisig support #253

wants to merge 2 commits into from

Conversation

matiu
Copy link
Contributor

@matiu matiu commented Dec 1, 2015

  • defines 48' a purpose for multisig wallets
  • adds p2sh address generate procedure
  • adds Copay to 'compatible wallets'

- defines 48' a purpose for multisig wallets
- adds p2sh address generate procedure
- adds Copay to 'compatible wallets'
@afk11
Copy link
Contributor

afk11 commented Dec 1, 2015

BIP's aren't usually amended after the fact, it might be an issue to introducing this a year and a half in.

@matiu
Copy link
Contributor Author

matiu commented Dec 1, 2015

Given that the multisig extension uses a new purpose number, I dont think there could be an issue.
This was done in coordination with the BIP author.

Note that there are some BIP are received conceptually similar extensions like:
2e6e5cf

@luke-jr
Copy link
Member

luke-jr commented Dec 11, 2015

It's still Draft status, so this just needs an ACK from @slush0 or @prusnak

@prusnak
Copy link
Contributor

prusnak commented Dec 11, 2015

NACK. This should go into BIP 48 according to BIP 43 specification.

@prusnak
Copy link
Contributor

prusnak commented Dec 11, 2015

Also you should clearly state in BIP 45 that this BIP is obsoleted by BIP 48.

@andre-amorim
Copy link

Time Stamp ?

On 11 December 2015 at 09:44, Pavol Rusnak notifications@github.com wrote:

NACK. This should go into BIP 48 according to BIP 43 specification.


Reply to this email directly or view it on GitHub
#253 (comment).


===Purpose===
Because seeds that are part of a multisignature wallet cannot be scanned individually, a different
purpose constant is must be used: 48'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo/grammar

a different purpose constant is must be used

@matiu
Copy link
Contributor Author

matiu commented Dec 11, 2015

OK, closing this one then. I will submit a new proposal.

This do not completely obsoletes BIP45, since with BIP45 it is possible to create wallet addresses without parties synchronization.

@matiu matiu closed this Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants