Update BIP173: new reference impls + tests fix #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK but at the bottom of decoding add: Implementations should take special care when converting the address to a ScriptPubkey: In Bitcoin script while 0 is encoded as 0x00 the numbers 1 through 16 are encoded as 0x51 though 0x60 (81 to 96 in decimal). If a bech32 address is converted to an incorrect scrippubkey the result will likely be either unspendable or insecure, either of which is undesirable. |
|
I agree with @gmaxwell that additional explanation is in order. Thankfully |
|
@gmaxwell Rewrote that a bit, and added it. |
sipa
added a commit
to sipa/bech32
that referenced
this pull request
Aug 4, 2017
0692344 Fix tests for non-v0 witnesses (Pieter Wuille) Pull request description: See corresponding BIP update: bitcoin/bips#565 Thanks @afk11 for pointing this out. Tree-SHA512: 02feee63502cabcefdae5dfdb87f6d7dd0171d7119a5d7a5f6a593c86aaabe603c2fc0fc47397084f7b86ac08a0723f8de06861814ca971d83a73ee85ea14a33
|
@luke-jr Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.