Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pseudocode on bip-0158 #769

Closed
wants to merge 1 commit into from
Closed

Fix pseudocode on bip-0158 #769

wants to merge 1 commit into from

Conversation

AlexITC
Copy link

@AlexITC AlexITC commented Mar 12, 2019

The golomb_encode function should encode r instead of x.

The golomb_encode function should encode r instead of x.
@luke-jr
Copy link
Member

luke-jr commented Mar 29, 2019

@Roasbeef @aakselrod

@AlexITC
Copy link
Author

AlexITC commented Apr 3, 2019

I'm not sure what the Proposed BIP modification tag is about, I'm not proposing to change the BIP but fixing a minor detail on the pseudocode.

@matthewleon
Copy link

This appears to be an unnecessary change to the pseudocode. See the Bitcoin core implementation: https://github.com/bitcoin/bitcoin/blob/667a8617418d837092de5b37568d60b372519462/src/blockfilter.cpp#L37

@AlexITC
Copy link
Author

AlexITC commented May 14, 2019

@mattBlackDesign in fact, it wasn't obvious to me that this line is writing the P least significant bits only, which is what I basically made clear: write_bits_big_endian(stream, r, P).

I'm closing the ticket.

@AlexITC AlexITC closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants