BIP340 updates: even R, new tags, small fixups, clarifications #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- key prefixing means prefixing the message - array indexing starts with 0 - 'Gennaro' is spelled with two n's - has_even_y definition takes P as argument Thanks to Alan Szepieniec for pointing out these issues.
Jacobi symbol can be confusing because it may suggest that the modulus is composite. Thanks to Alan Szepieniec for pointing out this issue.
Clarify security argument of x-only pubkeys
BIP-0340: Miscellaneous fixups
BIP340: Fix typo
Switch BIP340 to even R tiebreaker
Clarify that Jacobian coordinates are the optimization
|
@luke-jr I'm happy to rebase this to remove merge commits, but I believe you prefer it in this form? |
|
Yes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two semantics changes:
There are also a number of changes to the document that do not change semantics, but just improve clarity, or fix typos.