[QT] Bugfix: ensure tray icon menu is not empty #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my system (running Ubuntu 16.04, with the XFCE desktop), I am experiencing a bug in which the tray icon menu does not contain any content. This change resolves this bug by moving the `trayIcon->show()` call to be made after the `trayIcon->setContextMenu(trayIconMenu)` call.
|
The teamcity testing system gave an all green on this. |
|
Great find! Yeah, that code definitely looks better now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system (running Ubuntu 16.04, with the XFCE desktop), I am experiencing a bug in which the tray icon menu does not contain any content.
This change resolves this bug by moving the
trayIcon->show()call to be made after thetrayIcon->setContextMenu(trayIconMenu)call.