Use external uniffi library for rust-bitcoin types #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
4 times, most recently
from
fb7d9d8
to
30cf4af
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
4 times, most recently
from
a54f346
to
e5f0925
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
from
e5f0925
to
eaab4fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows our library to depend on an external bitcoin-ffi library. This is useful because it means we can collaborate with other projects who also need to use types from rust-bitcoin in their uniffi bindings.