-
Notifications
You must be signed in to change notification settings - Fork 14
Migrate project-level Gradle build script to Kotlin DSL #10
Conversation
b71f38a
to
7ab5ea5
Compare
I have migrated all 3 build scripts. A few notes:
|
I'm currently using |
The face when you realize your question is answered right there in the readme and now everyone knows you didn't read it meticulously: I have tested in a local repo and indeed the current code will fetch the username and password correctly from global properties. I'll mark this PR as ready for review. |
8d82af5
to
7ab5ea5
Compare
I merged the two pending PRs so now this one needs a rebase. Then I'll give it a test and otherwise LGTM. |
7ab5ea5
to
95ef8eb
Compare
It was a weird rebase but I think I got it. The issue was that you had made changes to files I had deleted, so I just needed to delete them again. |
implementation("net.java.dev.jna:jna:5.8.0") | ||
api("org.slf4j:slf4j-api:1.7.30") | ||
testImplementation("junit:junit:4.13.2") | ||
testRuntimeOnly("org.junit.vintage:junit-vintage-engine:5.8.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I had to add this dependency for the ./gradlew :jvm:test
command to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with the migration to the new API! This PR was initially made against the older version of bdk-ffi and so it was working, but when I worked on updating the tests in a different PR I also found I needed to add this junit-vintage-engine
. Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 933af8c
I tested a staging publish and it worked so a full (non-test) publish should work too.
Description
Migrating the Gradle build scripts to Kotlin DSL.
Fixes #9
Notes to the reviewers
I have not tested the publishing workflow.
All Submissions: