-
Notifications
You must be signed in to change notification settings - Fork 279
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(bdk): remove Psbt tap_* fields after final_script_witness constru…
…cted We currently allow removing `partial_sigs` from a finalized `Psbt`, which is relevant to non-taproot inputs, however taproot related `Psbt` fields were left in place despite the recommendation of BIP371 to remove them once the `final_script_witness` is constructed. This can cause confusion for parsers that encounter extra taproot metadata in an already satisfied input. Fix this by introducing a new memeber to SignOptions `remove_taproot_extras`, which when true will remove extra taproot related data from a `Psbt` upon successful finalization. This change makes removal of all taproot extras the default but configurable. fixes #1243
- Loading branch information
1 parent
c6b9ed3
commit fa46980
Showing
3 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters