Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Append trait to Merge #1467

Closed
LLFourn opened this issue Jun 7, 2024 · 1 comment · Fixed by #1502
Closed

Rename Append trait to Merge #1467

LLFourn opened this issue Jun 7, 2024 · 1 comment · Fixed by #1502
Assignees
@LagginTimes
Labels
api A breaking API change module-blockchain
Milestone
1.0.0-alpha

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Jun 7, 2024

I think this captures better what this is doing. I think it was originally named append since the underlying this always used the core append method but we stopped using that because it's not efficient anyway.
@notmandatory notmandatory added module-blockchain api A breaking API change labels Jun 23, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jun 23, 2024
@LagginTimes
Copy link
Contributor

I'll take a look at this if nobody else has.

@LagginTimes LagginTimes mentioned this issue Jul 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LagginTimes LagginTimes

Labels
api A breaking API change module-blockchain
Projects
BDK
Status: Done
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

chore(chain)!: Rename Append to Merge LagginTimes/bdk
3 participants
@LLFourn @notmandatory @LagginTimes