Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chain)!: Rename Append to Merge #1502

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

LagginTimes
Copy link
Contributor

Fixes #1467.

Description

Renames the Append trait to Merge.

Notes to the reviewers

Changelog notice

  • Rename bdk_chain::Append to bdk_chain::Merge.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4a12aac

@notmandatory notmandatory added the api A breaking API change label Jul 4, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 4, 2024
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4a12aac

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7b948d5

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 962305f

@notmandatory notmandatory merged commit 43f093d into bitcoindevkit:master Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A breaking API change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename Append trait to Merge
3 participants