Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Wallet::build_fee_bump to a TxBuilder method. #280

Open
LLFourn opened this issue Feb 8, 2021 · 0 comments
Open

Migrate Wallet::build_fee_bump to a TxBuilder method. #280

LLFourn opened this issue Feb 8, 2021 · 0 comments
Labels
new feature New feature or request

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Feb 8, 2021

This is unfinished business from #258.

Right now you can only bump the fee of one tx at a time by creating a fee bump TxBuilder by calling Wallet::build_fee_bump . Why not allow bumping the fee of multiple transactions?

I think this can be done by just having a bump_fee method on TxBuilder which takes a transaction and adds all the inputs and outputs to the internal state and recording the minimum fee for the fee bump to work.

@notmandatory notmandatory added the new feature New feature or request label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants