Get block hash by its height #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
requested changes
Jun 17, 2022
vladimirfomene
force-pushed
the
implement-getblockhash-by-height
branch
from
6f3528b
to
0822cc0
Compare
|
@danielabrozzoni I have amended the code based on your recommendation. @evanlinjin I have also fixed the import issue. The test is passing for all blockchains but while testing against |
|
That looks like a spurious error... In CI, compact filters compilation is failing. You can reproduce with |
vladimirfomene
force-pushed
the
implement-getblockhash-by-height
branch
2 times, most recently
from
62b00fb
to
d0efd4d
Compare
danielabrozzoni
approved these changes
Jul 6, 2022
Comment on lines
265
to
271
| let block_hash = self.headers.get_block_hash(height as usize)?; | ||
| match block_hash { | ||
| Some(block_hash) => Ok(block_hash), | ||
| None => Err(Error::CompactFilters( | ||
| CompactFiltersError::BlockHashNotFound, | ||
| )), | ||
| } |
There was a problem hiding this comment.
nit: you can re-write this as
self.headers.get_block_hash(height as usize)?.ok_or(Error::CompactFilters(
CompactFiltersError::BlockHashNotFound,
))
ok_or makes it way more compact :)
vladimirfomene
force-pushed
the
implement-getblockhash-by-height
branch
from
d0efd4d
to
2b6801b
Compare
|
Also, you have conflicts with the changelog :( |
vladimirfomene
force-pushed
the
implement-getblockhash-by-height
branch
from
2b6801b
to
b985b12
Compare
|
@danielabrozzoni, thanks for pointing that out. Fixed! |
Create blockchain::GetBlockHash trait with a method to get block hash given a block height. Then, implement this trait for all backends (Electrum, RPC , Esplora, CBF). Referenced in issue 603.
vladimirfomene
force-pushed
the
implement-getblockhash-by-height
branch
from
b985b12
to
2af678a
Compare
notmandatory
approved these changes
Jul 6, 2022
9 tasks
notmandatory
added a commit
to bitcoindevkit/rust-esplora-client
that referenced
this pull request
Aug 2, 2022
758dba1 Get block hash by its height (Vladimir Fomene) Pull request description: ### Description This PR create a new trait `blockchain::GetBlockHash` with a `get_block_hash` method which returns a block hash given the block height. This has been implemented for all blockchain backends. Fixes #603 ### Notes to the reviewers I haven't updated the `CHANGELOG.md` and docs. Am I suppose to update it for this change? ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [ ] I've added docs for the new feature * [ ] I've updated `CHANGELOG.md` ACKs for top commit: notmandatory: ACK 758dba1 Tree-SHA512: 9c084a6665ecbf27ee8170fdb06e0dc8373d6a901ce29e5f5a1bec111d1507cb3bee6b03a653a55fd20e0fabe7a5eada3353e24a1e21f3a11f01bb9881ae99e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR create a new trait
blockchain::GetBlockHashwith aget_block_hashmethod which returns a block hash given the block height. This has been implemented for all blockchain backends.Fixes #603
Notes to the reviewers
I haven't updated the
CHANGELOG.mdand docs. Am I suppose to update it for this change?Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md