Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TransactionDetails from Wallet API #1048

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Remove TransactionDetails from Wallet API #1048

merged 6 commits into from
Aug 31, 2023

Commits on Aug 30, 2023

  1. feat(wallet)!: remove TransactionDetails from bdk::Wallet API 

    Added
- Wallet::sent_and_received function
- Wallet::calculate_fee and Wallet::calculate_fee_rate functions
- Wallet::error::CalculateFeeError

BREAKING CHANGES:

Removed
- TransactionDetails struct

Changed
- Wallet::get_tx now returns CanonicalTx instead of TransactionDetails
- TxBuilder::finish now returns only a PartiallySignedTransaction
    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b4c31cd View commit details
    Browse the repository at this point in the history

  2. feat(tx_graph)!: change TxGraph::calculate_fee to return Result<u64,C… 

    …alculateFeeError>

added
- tx_graph::CalculateFeeError enum

BREAKING CHANGES:

changed
- TxGraph::calculate_fee function to return Result<u64,CalculateFeeError> instead of Option<i64>
    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d443fe7 View commit details
    Browse the repository at this point in the history

  3. feat(wallet): add Wallet::insert_txout function and updated docs for … 

    …fee functions

added
    - Wallet::insert_txout function to allow inserting foreign TxOuts
    - test to verify error when trying to calculate fee with missing foreign utxo
    - test to calculate fee with inserted foreign utxo

updated
    - docs for Wallet::calculate_fee, Wallet::calculate_fee_rate, and TxGraph::calculate_fee
      with note about missing foreign utxos
    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0362998 View commit details
    Browse the repository at this point in the history

  4. docs(wallet): update docs for calculate_fee/fee_rate and add_foreign_… 

    …utxo
    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    465d53c View commit details
    Browse the repository at this point in the history

  5. test(wallet): add check_fee!(wallet,psbt) macro and use it in place o… 

    …f psbt.fee_amount()

- removed test_calculate_fee_with_inserted_foreign_utxo() since it now duplicates test in test_add_foreign_utxo()
    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    dd5b8d7 View commit details
    Browse the repository at this point in the history

  6. ci: fix msrv dependency versions for rustls

    @notmandatory
    notmandatory committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5fb5061 View commit details
    Browse the repository at this point in the history