Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apply_update instead of determine_changeset + apply_changeset around the code #1092

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Use apply_update instead of determine_changeset + apply_changeset around the code #1092

merged 1 commit into from
Aug 25, 2023

Conversation

LagginTimes
Copy link
Contributor

This PR implements #1081

vladimirfomene
vladimirfomene approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ACK 395a1f7

evanlinjin
evanlinjin approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 395a1f7

@evanlinjin
Copy link
Member

@LagginTimes can you sign your commits? Thanks

evanlinjin
evanlinjin approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c753584

@evanlinjin evanlinjin merged commit 381c560 into bitcoindevkit:master Aug 25, 2023
12 checks passed
@evanlinjin evanlinjin mentioned this pull request Aug 25, 2023
Closed
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Sep 1, 2023
@notmandatory notmandatory mentioned this pull request Oct 11, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirfomene vladimirfomene vladimirfomene approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LagginTimes @evanlinjin @vladimirfomene @notmandatory