Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dependabot #1121

Merged

Conversation

realeinherjar
Copy link
Contributor

Fixes #1118.
Adds dependabot.yml to .github/ to check for "github-action" updates on a "weekly" basis.
This does not touch Rust code or Cargo workflows.

It will create PRs and we would need to approve them (they would be subject to the same merge policy)
to instantiate the proposed dependabots into master.

Changelog notice

Added dependabot to automatically check GitHub Actions updates.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory
Copy link
Member

notmandatory commented Nov 13, 2023

Added this to first beta release milestone since it's not a functional change.

@realeinherjar
Copy link
Contributor Author

It is ready to merge.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5aa8c7f

notmandatory added a commit to notmandatory/bdk that referenced this pull request Nov 14, 2023
5aa8c7f feat: add dependabot (Einherjar)

Pull request description:

  Fixes bitcoindevkit#1118.
  Adds `dependabot.yml` to `.github/` to check for `"github-action"` updates on a `"weekly"` basis.
  This does not touch Rust code or Cargo workflows.

  It will  create PRs and we would need to approve them (they would be subject to the same merge policy)
  to instantiate the proposed dependabots into `master`.

  ### Changelog notice

  Added dependabot to automatically check GitHub Actions updates.

  ### Checklists

  #### All Submissions:

  * [X] I've signed all my commits
  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [X] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [X] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 5aa8c7f

Tree-SHA512: aca47d955849c24981a9c485775ce7e389a5b5b274fcd114f6e4583c2bf04f94fcd34e183064cd1da66db3560134b60feb0564ea42cbf97cb78d2c5e1aac0a1b
Fixes bitcoindevkit#1118.
Adds `dependabot.yml` to `.github/` to check for `"github-action"`
updates on a `"weekly"` basis.
This does not touch Rust code or Cargo workflows.

It will  create PRs and we would need to approve them
(they would be subject to the same merge policy)
to instantiate the proposed dependabots into `master`.
@notmandatory
Copy link
Member

I had to amend your commit to get it signed, will merge it after the workflow tests finish.

@notmandatory notmandatory merged commit d6a0cf0 into bitcoindevkit:master Nov 14, 2023
12 checks passed
@realeinherjar
Copy link
Contributor Author

Sorry about that, I did a GPG key rotation and I need to amend everything.
Thanks!

@realeinherjar realeinherjar deleted the einherjar/dependabot.yml branch November 14, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI: dependabot to automate GitHub actions updates
2 participants