Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bdk dependency on log and dev dependency on env_logger #1204

Merged

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 11, 2023

Description

As suggested by @TheBlueMatt we shouldn't use the log crate because even though it is a rust-lang project is may depend on some other crates that aren't as well maintained. Since we were only use log in a few places and not it any other bdk workspace projects except the bdk package I removed it.

Notes to the reviewers

For consistency I also removed the env_logger from the dev dependencies since it was only being used in a few places in a couple examples and println! is adequate for examples.

Changelog notice

None

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added this to the 1.0.0-alpha.3 milestone Nov 11, 2023
@notmandatory notmandatory self-assigned this Nov 11, 2023
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 18e9e0a

@danielabrozzoni
Copy link
Member

Should we open an issue to introduce some sort of diy logger as ldk does?

ACK 18e9e0a

@notmandatory notmandatory mentioned this pull request Nov 16, 2023
@notmandatory
Copy link
Member Author

Should we open an issue to introduce some sort of diy logger as ldk does?

I just created a placeholder issue.

@notmandatory
Copy link
Member Author

rebased

@notmandatory notmandatory merged commit 73862be into bitcoindevkit:master Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants