Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename ConfirmationTimeAnchor to ConfirmationTimeHeightAnchor #1206

Merged

Conversation

LagginTimes
Copy link
Contributor

@LagginTimes LagginTimes commented Nov 12, 2023

Description

Closes #1187.
An Anchor implementation that records both height and time should have both attributes included in the name.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

An `Anchor` implementation that records both height and time should have
both attributes included in the name.
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0112c67

@danielabrozzoni danielabrozzoni merged commit e71770f into bitcoindevkit:master Nov 14, 2023
12 checks passed
@notmandatory notmandatory mentioned this pull request Jan 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename ConfirmationTimeAnchor to ConfirmationTimeHeightAnchor
3 participants