Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Pin jobserver after cc #1207

Merged
merged 1 commit into from
Nov 13, 2023
Merged

ci: Pin jobserver after cc #1207

merged 1 commit into from
Nov 13, 2023

Conversation

danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Nov 13, 2023 •
edited
Loading

Since now only cc depends on jobserver, it should be pinned after we pin cc

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni self-assigned this Nov 13, 2023
@danielabrozzoni danielabrozzoni added this to the 1.0.0-alpha.3 milestone Nov 13, 2023
@danielabrozzoni danielabrozzoni changed the title ci: Remove jobserver pin ci: Pin jobserver after cc Nov 13, 2023
@danielabrozzoni
ci: Pin jobserver after cc
298f6cb 
Since now only cc depends on jobserver, it should be pinned after we pin cc
notmandatory
notmandatory approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 298f6cb

@notmandatory notmandatory merged commit 298f6cb into bitcoindevkit:master Nov 13, 2023
12 checks passed
@danielabrozzoni danielabrozzoni mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielabrozzoni @notmandatory