-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/rename electrum_ext and esplora_ext to have sync and full_scan functions #1235
Refactor/rename electrum_ext and esplora_ext to have sync and full_scan functions #1235
Conversation
|
Oh ya, I was thinking that poll was for |
c761103
to
d570398
Compare
a467077
to
4cb781b
Compare
Functions renamed plus I updated the docs. |
4cb781b
to
b9cbcc3
Compare
b9cbcc3
to
8ef37d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I ran the esplora tests - all ok.
4974d61
to
d36db4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d36db4d
Much nicer thanks.
side note: the docs here are stale: d36db4d8df8173d92b9cdeb4fa9877ca77f56d20. There is no argument prev_tip
to update_local_chain
.
d36db4d
to
264d58a
Compare
fixed! |
… to full_scan removed txids and outpoints params from full_scan
…hains to full_scan removed txids and outpoints params from full_scan
264d58a
to
de54e71
Compare
Description
fixes #1112
Simple function renaming plus updated docs:
scan_without_keychain
tosync
andscan
tofull_scan
scan_txs
tosync
andscan_txs_with_keychains
tofull_scan
Notes to the reviewers
The esplora_ext changes were partially fixed in #1070 but I renamed again so the functions match names
suggested in #1112agreed on in discord poll,sync
andfull_scan
.Changelog notice
Changed
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing