Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(electrum_ext): fix docs for `RelevantTxids::into_confirmation_tim… #1289

Merged

Conversation

ValuedMammal
Copy link
Contributor

Note also, the bit referring to Electrum's API sounds more like a developer note, so I made it a regular code comment.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are much clearer now, thanks!

ACK cf0c333

@danielabrozzoni danielabrozzoni merged commit 99661be into bitcoindevkit:master Jan 22, 2024
12 checks passed
@ValuedMammal ValuedMammal deleted the doc/electrum-relevant-txids branch January 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants