Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ElectrumExt for all that implements ElectrumApi #1306

Conversation

evanlinjin
Copy link
Member

Description

Implement ElectrumExt for all that implements ElectrumApi.

I realized this while looking into #1171.

let env = TestEnv::new()?;
let client = electrum_client::Client::new(env.electrsd.electrum_url.as_str())?;

Line 55 here should not be necessary.

Changelog notice

  • Changed to implement ElectrumExt for all that implements ElectrumApi.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@evanlinjin evanlinjin self-assigned this Jan 31, 2024
@evanlinjin evanlinjin added the enhancement New feature or request label Jan 31, 2024
@notmandatory notmandatory mentioned this pull request Jan 31, 2024
23 tasks
@evanlinjin evanlinjin force-pushed the electrum_ext_impls_for_raw_clients branch from 5a7a177 to ce8c617 Compare January 31, 2024 14:47
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ce8c617

@notmandatory notmandatory added this to the 1.0.0 milestone Jan 31, 2024
@notmandatory notmandatory merged commit f099b42 into bitcoindevkit:master Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants