tx_builder: Support setting explicit nSequence for foreign inputs #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
force-pushed
the
foreign-sequence
branch
from
2b5716d
to
73c5736
Compare
evanlinjin
reviewed
Feb 2, 2024
stevenroose
force-pushed
the
foreign-sequence
branch
from
73c5736
to
9bb39a3
Compare
evanlinjin
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
ACK 9bb39a3
When we change to use PSBT v2, we can remove this (as the sequence will be part of the psbt input).
|
Oh yeah that's true. I was looking for a sequence field in the input, but psbt v1 works on already-finish tx structure I guess. Not sure how the psbtv2 flow will work for this. I guess it has one more "creation" phase to go through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1315.