tx_builder: Relax generic constraints on TxBuilder #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storopoli
reviewed
Feb 16, 2024
|
I don't think it's needed here. With generic constraints: if it compiles, it works. The lower the better. Is there something I can/should do about the canceled CI builds? |
|
I agree there's no need for tests on this and its best to relax generic constraints as much as possible in rust. No idea what CI is doing. @notmandatory any ideas? |
It is not needed anymore. Discovered in bitcoindevkit#1344
|
To be fair I'm not sure why the CI is failing only in this PR, while others are passing (maybe it's just that other PRs aren't touching the bdk code, and the CI cache is ✨ caching ✨ it?) Anyways, I opened #1357 to fix, once that's merged, can you rebase please? |
stevenroose
force-pushed
the
relax-txbuilder-impls
branch
from
d48f970
to
2efa299
Compare
|
Rebased on top of #1357, so let's see if that fixes CI. |
|
#1357 is merged and it looks like all tests are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1312