fix(persist): add default feature to enable bdk_chain/std #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nevermind! I was able to publish cargo publish --features bdk_chain/std |
7 tasks
|
@ValuedMammal per your comment in #1422 I agree, doesn't hurt to get this fixed so docs build in our next alpha. @oleonardolima can revert this change as part of the rust-bitcoin 0.32 update. |
|
ACK a577c22 |
storopoli
approved these changes
May 7, 2024
ValuedMammal
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
defaultfeature tobdk_persistso it can be build on its own. Once #1422 is done we can remove thedefaultagain.Notes to the reviewers
I need to be able to build
bdk_persiston its own so I can publish it to crates.io.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing