Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin cc dependency version to build with rust 1.63 #1505

Merged
merged 1 commit into from
Jul 8, 2024
Merged

ci: pin cc dependency version to build with rust 1.63 #1505

merged 1 commit into from
Jul 8, 2024
+2 −0

Conversation

LagginTimes
Copy link
Contributor

@LagginTimes LagginTimes commented Jul 8, 2024 •
edited
Loading

Description

cc version 1.0.106 raised msrv to 1.67.
The previous working version 1.0.105 was pinned for CI to continue working.

Notes to the reviewers

Changelog notice

  • Pinned cc dependency version to build with rust 1.63.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

storopoli
storopoli approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f9ed95

Thanks!

notmandatory
notmandatory approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f9ed95

@notmandatory notmandatory merged commit 1a39821 into bitcoindevkit:master Jul 8, 2024
12 checks passed
@notmandatory notmandatory added the ci label Jul 8, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@storopoli storopoli storopoli approved these changes

Assignees

@LagginTimes LagginTimes

Labels
ci
Projects
BDK
Status: Done
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LagginTimes @notmandatory @storopoli