Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation policy to CONTRIBUTING.md #422

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Add deprecation policy to CONTRIBUTING.md #422

merged 1 commit into from
Aug 25, 2021

Conversation

thomaseizinger
Copy link
Contributor

Description

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thomaseizinger thomaseizinger mentioned this pull request Aug 17, 2021
Closed
@notmandatory
Copy link
Member

LGTM, will leave this open to give any other contributors time to comment and until we have a chance to discuss live at our next team meeting.

afilini
afilini approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, now that the library is starting to get more stable we can afford to do this rather than just breaking the API straight away

@notmandatory notmandatory merged commit 7117557 into bitcoindevkit:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afilini afilini afilini approved these changes

@LLFourn LLFourn LLFourn approved these changes

@notmandatory notmandatory notmandatory approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thomaseizinger @notmandatory @afilini @LLFourn @tcharding