Update dev-dependencies electrsd to 0.10 and required additional crates #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
ci/update_electrsd
branch
6 times, most recently
from
a31a381
to
1d91aee
Compare
3 tasks
notmandatory
force-pushed
the
ci/update_electrsd
branch
from
70c9d00
to
8a4141f
Compare
notmandatory
changed the title
….27 and miniscript to ^6.0
notmandatory
force-pushed
the
ci/update_electrsd
branch
from
8a4141f
to
ea56a87
Compare
notmandatory
changed the title
notmandatory
changed the title
LLFourn
reviewed
Aug 17, 2021
| @@ -87,7 +87,7 @@ test-md-docs = ["electrum"] | |||
| lazy_static = "1.4" | |||
| env_logger = "0.7" | |||
| clap = "2.33" | |||
| electrsd = { version= "0.8", features = ["trigger", "bitcoind_0_21_1"] } | |||
| electrsd = { version= "0.10", features = ["trigger", "bitcoind_0_21_1"] } | |||
There was a problem hiding this comment.
With this upgrade you can get rid of extra cache lines in workflow too I think: https://github.com/bitcoindevkit/bdk/blob/master/.github/workflows/cont_integration.yml#L98
afilini
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CI by upgrading dev-dependencies electrsd to ^0.10. See required PRs rust-bitcoin/bitcoind#18 and RCasatta/electrsd#15.
Notes to the reviewers
The new electrsd will use
OUT_DIRinstead ofCARGO_HOMEto store bitcoind and electrsd executables. To be able to useelectrs^0.10 I also had to change dependencies bitcoincore-rpc to core-rpc, update bitcoin to ^0.27 and miniscript to ^6.0.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing