-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logo #497
Update logo #497
Conversation
this reminds me that is possible to change the logo also in the documentation, see https://www.davideaversa.it/blog/how-to-add-a-logo-in-rust-documentation/ |
ACK. Also on rust.doc as mentioned by @RCasatta . |
It's weird we're getting this clippy error, I think it has something to do with the macro running with nightly since this warning is only present in master/nightly: https://rust-lang.github.io/rust-clippy/master/index.html#no_effect_underscore_binding |
I'm a bit stumped on this Any ideas? Reproduce with: cargo +1.46.0 clippy --all-targets --features async-interface --no-default-features |
I am not getting the error in 1.46.0, 1.47.0 and 1.56.0. Though I am getting a new clippy error in stable and nightly (1.57.0 and 1.59.0). Probably that's due to some recent changes in 1.57.0.
They seem unrelated to this error and straight forward, probably something we need to deal in next latest stable update. But I can't reproduce the Is it possible to rerun the CI tests? |
Now that #501 is in you can rebase on |
I can do this in another PR once this is merged, so that i can point the url to the image hosted on github. Otherwise I have to upload it somewhere else just to have a publicly accessible url that i can use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 77bce06
As suggested in bitcoindevkit#497, add our logo to the docs as well
Description
Update the logo in our readme