Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive PartialEq, Eq on SyncTime #837

Merged
merged 1 commit into from Jan 30, 2023
Merged

Derive PartialEq, Eq on SyncTime #837

merged 1 commit into from Jan 30, 2023

Conversation

MaxFangX
Copy link
Contributor

@MaxFangX MaxFangX commented Jan 19, 2023 •
edited

Description

This enables e.g. assert_eq! comparisons of SyncTime in tests (we use this)

Changelog notice

Derived PartialEq, Eq on SyncTime

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory
Copy link
Member

Looks good, we just changed our CI MSRV so you'll need to do a rebase to pick that up.

@notmandatory notmandatory added the enhancement New feature or request label Jan 28, 2023
@notmandatory notmandatory mentioned this pull request Jan 28, 2023
Closed
23 tasks
@MaxFangX
Derive PartialEq, Eq on SyncTime
45d4141 
This enables e.g. `assert_eq!` comparisons of `SyncTime` in tests.
@MaxFangX
Copy link
Contributor Author

@notmandatory rebased, awaiting approval again for running CI

rajarshimaitra
rajarshimaitra approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 45d4141

evanlinjin
evanlinjin approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 45d4141

No-brainer.

@notmandatory notmandatory merged commit e678aad into bitcoindevkit:master Jan 30, 2023
@MaxFangX MaxFangX deleted the synctime-derive branch January 31, 2023 01:44
@notmandatory notmandatory mentioned this pull request Feb 2, 2023
Closed
24 tasks
@evanlinjin evanlinjin mentioned this pull request Apr 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@MaxFangX MaxFangX

Labels
enhancement New feature or request
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.27.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaxFangX @notmandatory @evanlinjin @rajarshimaitra