Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add small clarification to docs #838

Merged
merged 1 commit into from Feb 2, 2023
Merged

Add small clarification to docs #838

merged 1 commit into from Feb 2, 2023

Conversation

thunderbiscuit
Copy link
Contributor

Description

Very small fixes to documentation:

  1. I got a DM last week from a user who thought we had a bug with our timestamps. It turns out he was using the milliseconds version of the Unix timestamp in his project and didn't realize we were giving out a standard Unix timestamp. The docs now mention this explicitly.
  2. I noticed some small inconsistencies in the documentation on the public templates while porting them over to Kotlin. This PR also fixes that so that all templates use a common documentation wording.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@thunderbiscuit thunderbiscuit self-assigned this Jan 19, 2023
@thunderbiscuit thunderbiscuit added the documentation Improvements or additions to documentation label Jan 19, 2023
notmandatory
notmandatory approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bd18338

@notmandatory notmandatory mentioned this pull request Jan 30, 2023
Merged
8 tasks
notmandatory
notmandatory approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK f0cec01

Putting this into 0.27.0 since it is only doc changes.

@notmandatory notmandatory merged commit 35bbe2b into bitcoindevkit:master Feb 2, 2023
@thunderbiscuit thunderbiscuit deleted the small-docs-refactor branch February 2, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@thunderbiscuit thunderbiscuit

Labels
documentation Improvements or additions to documentation
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.27.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thunderbiscuit @notmandatory