-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bitcoin to v0.31 #121
Upgrade bitcoin to v0.31 #121
Conversation
be333cf
to
5a3439a
Compare
5a3439a
to
ca56216
Compare
This all looks good to me, I only have one small nit, can you change your commit message to indicate this updates bitcoin to 0.31.0, it currently says 0.31.0-rc1. |
Upgrade bitcoin dependency to `rust-bitcoin v0.31.0`: Allows us to remove the dependency on `bitcoin-private` because the `hex` stuff is exposed by `bitcoin` now.
ca56216
to
dd3c171
Compare
Of course, my bad. |
Force push is change of commit log only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK dd3c171
Have you got a release queued up already @notmandatory? Can you ping me, if you think of it, when it drops and I'll push on with the other upgrades. No stress, it just popped into my head. |
I'll do a |
can't see the |
I was planning to merge #128 when I'm back home on Tues and then add the 0.19.0 tag. But if someone can get to it sooner please go ahead. |
Upgrade bitcoin dependency to
rust-bitcoin v0.31.0-rc1
:Allows us to remove the dependency on
bitcoin-private
because thehex
stuff is exposed bybitcoin
now.EDIT: Post merge edite, the upgrade was to
v0.31.0
not the rc1 release.