Config #27
Merged
Config #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
force-pushed
the
config
branch
3 times, most recently
from
daa7616
to
39a87c1
Compare
Retry works by checking if an non-protocol error happened during the call, if so an attempt to take a write lock on the client is made and a new client attempted if both operationare succesfull the old_client is substituted with the new one. Timeout is a single parameter for connect,read and write TCP timeouts, special handling is required for the following situation: cannot set a timeout with a proxy and cannot set timeout with multipl SocketAddrs Since configurations parameter grow, a Config struct with a builder has been introduced Some new errors variant has been introduced Errors in reading input in the reader thread now warns other eventual threads with ChannelMessage::Error Add github actions equivalent to travis cause travis is slow
afilini
reviewed
Nov 25, 2020
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Dec 17, 2020
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Dec 17, 2020
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Dec 23, 2020
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Jan 6, 2021
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Feb 27, 2021
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
shesek
added a commit
to shesek/gdk
that referenced
this pull request
Feb 27, 2021
It now has native support for setting the socket timeout, implemented in bitcoindevkit/rust-electrum-client#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements retry, timeout, socks credential and others fixes
Retry works by checking if an non-protocol error happened during the call, if so an attempt to take a write lock on the client is made and a new client attempted
if both operationare succesfull the old_client is substituted with the new one.
Timeout is a single parameter for connect,read and write TCP timeouts, special handling is required for the following situation: cannot set a timeout with a proxy and cannot set timeout with multipl SocketAddrs
Since configurations parameter grow, a Config struct with a builder has been introduced
Some new errors variant has been introduced
Errors in reading input in the reader thread now warns other eventual threads with ChannelMessage::Error
Add github actions equivalent to travis cause travis is slow