-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate errors from Esplora backends #58
Propagate errors from Esplora backends #58
Conversation
1170f15
to
abe1071
Compare
e92ea4d
to
604bca6
Compare
39ec52f
to
bf2b0c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bf2b0c2
Looks good, just one comment that should be cleaned up before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bf2b0c2
Great job. Just remove the println!
as @notmandatory suggested.
bf2b0c2
to
76dc3ae
Compare
Pull Request Test Coverage Report for Build 6363963533Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Quick fix for #47