Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate errors from Esplora backends #58

Merged

Conversation

vladimirfomene
Copy link
Contributor

Quick fix for #47

@vladimirfomene vladimirfomene force-pushed the expose_electrum_errors branch 25 times, most recently from e92ea4d to 604bca6 Compare September 28, 2023 06:17
@vladimirfomene vladimirfomene force-pushed the expose_electrum_errors branch 12 times, most recently from 39ec52f to bf2b0c2 Compare September 30, 2023 16:36
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bf2b0c2

Looks good, just one comment that should be cleaned up before merging.

src/lib.rs Outdated Show resolved Hide resolved
Copy link

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bf2b0c2

Great job. Just remove the println! as @notmandatory suggested.

src/lib.rs Outdated Show resolved Hide resolved
@vladimirfomene vladimirfomene merged commit 269360f into bitcoindevkit:master Oct 2, 2023
15 checks passed
@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 6363963533

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 80 of 158 (50.63%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.3%) to 79.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/async.rs 43 74 58.11%
src/blocking.rs 4 51 7.84%
Files with Coverage Reduction New Missed Lines %
src/blocking.rs 7 58.6%
Totals Coverage Status
Change from base Build 5409842518: -1.3%
Covered Lines: 907
Relevant Lines: 1143

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants