Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msrv1411 feature to pin once_cell to version =1.14 #73

Merged

Conversation

notmandatory
Copy link
Member

This is a bit of a hack, but if we make the pinned version of once_cell an optional feature, then only downstream projects that need the older version can opt-in to it by enabling the "msrv1411" feature. For example if I do this:

[dependencies]
hwi = { path = "../rust-hwi", features = ["msrv1411"] }

Then cargo update will set the Cargo.lock version of once_cell to 1.14.0. But if I don't include the feature:

[dependencies]
hwi = { path = "../rust-hwi" }

Then when I do cargo update the Cargo.lock version of once_cell is changed to 1.17.1.

I'm not in love with the feature name msrv1411 if you like this approach and have any better ideas.

@notmandatory
Copy link
Member Author

notmandatory commented Feb 22, 2023

I think CI is failing for unrelated reasons 😢

@danielabrozzoni
Copy link
Member

Omg thank you! This works perfectly. I just tested it with tauri and it works as intended :)
The CI is failing because of the ledger dockerfile, same issue we had on bdk. I'll merge a PR fixing it, then can you rebase on top of it?

Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 056422d

@danielabrozzoni danielabrozzoni merged commit 99a830f into bitcoindevkit:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants