Remove lazy parsing of messages. #1052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice, it will be a breath of fresh air to get rid of this stuff. As Travis is happy and the changes look reasonable at first glance, I am happy. Have you synced a wallet with these changes? If so, let's merge. |
schildbach
force-pushed
the
message-remove-lazy
branch
from
6a77694
to
1bdde82
Compare
In particular: * Message.parsed: removed * Message.parseLite(): folded into Message.parse() * Message.maybeParse(): removed * Message.ensureParsed(): removed * Message.isParsed(): removed * Block.parseHeader(): folded into Block.parse() * Block.parseTransactions(): folded into Block.parse() * Block.maybeParseHeader(): removed * Block.maybeParseTransactions(): removed * Block.ensureParsedHeader(): removed * Block.ensureParsedTransactions(): removed * Block.isParsedHeader(): removed * Block.isParsedTransasctions(): removed * MessageSerializer.isParseLazyMode(): removed * BitcoinSerializer.parseLazy: removed * BitcoinSerializer.getSerializer(): parseLazy parameter removed * LazyParseException: removed * LazyParseByteCacheTest: renamed to ParseByteCacheTest
|
Replaying my testnet wallet with this patch yields exactly the same transactions and the same balance as 0.13 (after fixing the Wallet.reset() issue on both branches). |
schildbach
force-pushed
the
message-remove-lazy
branch
from
1bdde82
to
d26dd7c
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular: