Add script verification flags for DER format #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnicoll
force-pushed
the
bip66
branch
2 times, most recently
from
9066084
to
26d1825
Compare
|
Have now fixed the excessive log spam that was upsetting Travis. |
| @@ -109,5 +109,9 @@ | |||
| [[["ad503f72c18df5801ee64d76090afe4c607fb2b822e9b7b63c5826c50e22fc3b", 0, "0x21 0x027c3a97665bf283a102a587a62a30a0c102d4d3b141015e2cae6f64e2543113e5 CHECKSIG NOT"]], | |||
| "01000000013bfc220ec526583cb6b7e922b8b27f604cfe0a09764de61e80f58dc1723f50ad0000000000ffffffff0101000000000000002321027c3a97665bf283a102a587a62a30a0c102d4d3b141015e2cae6f64e2543113e5ac00000000", "P2SH"], | |||
|
|
|||
| ["A transaction with a non-standard DER signature."], | |||
There was a problem hiding this comment.
I take it you created these test cases yourself? That's great!
There is only one issue with that: we sync these .json files from Bitcoin Core on a regular basis. So maybe you can submit your testcases to Core too?
Add script verification flags for DER format encoding, low-S signatures and strict encoding. Pass script verification flags through to signature parser. Convert block verification flags to a sub-enum of Block. Remove DER signature format verification flag from block flags. Add test transaction with a non-standard DER signature, with the verify flag set/unset accordingly, to tx_invalid.json and tx_valid.json
|
Okay, just cutting & pasting in the Bitcoin script tests isn't as trivial as I thought, I'll look at syncing both test data sets later on. Bitcoin doesn't have a transaction test (my mistake), so I have submitted the two test cases as bitcoin/bitcoin#6848. Unused "{}" removed as well. |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script verification flags for DER format encoding, low-S signatures and strict encoding.
Pass script verification flags through to signature parser.
Convert block verification flags to a sub-enum of Block.
Remove DER signature format verification flag from block flags.
Add test transaction with a non-standard DER signature, with the verify flag set/unset accordingly, to tx_invalid.json and tx_valid.json
Note this changes behaviour of Script.correctlySpends(Transaction, long, Script) as the method applies all flags, which now includes the new DER flag. The method version which takes in flags as an argument is unaffected.