Remove Orchid forked subproject and support for connecting via Tor. #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using bitcoinj as a library and I'm happy to get rid of orchid and related dependencies 👍 |
schildbach
force-pushed
the
remove-orchid
branch
from
ef2310b
to
8d353a5
Compare
|
Given Orchid has little maintenance and hasn't kept up with Tor updates I agree. It also had problems on Android and I think it stopped working with Android 6 or 7 not sure if it that was caused by some Android update and if it was then fixed as we moved to support tor via socks5 proxy and Orbot rather than using Orchid. |
schildbach
force-pushed
the
remove-orchid
branch
from
8d353a5
to
7e609a2
Compare
|
Thanks for your feedback. Merged. |
This was referenced Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to remove Orchid and with it support for connecting via Tor from bitcoinj. The feature was never really used. Those who tried reported issues and Orchid hasn't been maintained for ~3 years. On the other hand, the way how bitcoinj depends on Orchid has repeatedly caused build/dependency errors and bloats the binary size for those who do not need Tor.
If anyone wants to volunteer for the job of maintaining the Tor feature, we should find a way to plug in Orchid in a way to that the depencency is optional. I would be happy to move Orchid to a separate repository under the bitcoinj GitHub organization in this case so it can keep its home.