Fix for issue 539, adds atomic operation for changing wallet encryption key and password. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes that's the right lock, but you need to use a try/finally so the lock isn't held permanently if an exception is thrown. |
|
Fixed |
|
Can you fix the formatting? Space between "try" and "{", and no newline between "}" and "finally". |
|
Formatting fixed. |
|
Looks good to me! |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://code.google.com/p/bitcoinj/issues/detail?id=539
Please verify if I'm using correct lock. Two options are:
lockorkeychainLock