-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle.yml: add macos-14
(aarch64) to the build Matrix.
#3345
gradle.yml: add macos-14
(aarch64) to the build Matrix.
#3345
Conversation
|
Worth trying a rebase, I guess. |
`macos-15` will run on a macOS "Apple Silicon"/M1 Macintosh.
3183718
to
06205cf
Compare
Well the rebase didn't fix it. And no surprise now that I'm reading the error more carefully. 🤣 "When all else fails, carefully read the error message". There is no macOS/aarch64 JDK 8. So we should probably probably get the |
I made a test commit to see if And yes, it does resolve the issue. I think it is valuable for us to test on JDK8, so I'd rather not remove this test entirely, but turn it off on macOS/aarch64 (or maybe all macOS) |
macos-14
to the build Matrix.macos-14
(aarch64) to the build Matrix.
I think it doesn't hurt to disable it for all macOS. |
I wonder why is |
The |
Note that I suppose if we wish to avoid having the runner OS change automatically we could switch to using the tags that specify specific versions and then change manually when we want to upgrade. That might be a better way of doing things as it is a little more reproducible and it would clearly mark in Git history when we switched OS versions in tests. |
Yes, that's how we usually declare dependencies, I think. |
GitHub has bumped macos-latest to be macos-14 (and ARM) so our tests are currently broken. This PR is a short-term fix to restore the status quo and makes the minimum change to fix the broken build. See bitcoinj#3345 for more discussion.
Well "spring has sprung" and our build is now broken on macOS. (i.e. PR #3379 resolves the issue and restores previous behavior in the simplest way possible. |
Closing in favor of PR #3455 |
macOS-14
will run on a macOS "Apple Silicon"/M1 Macintosh.