Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tweak() method for BIP32Interface #66

Merged
merged 6 commits into from
Sep 25, 2022
Merged

Add tweak() method for BIP32Interface #66

merged 6 commits into from
Sep 25, 2022

Conversation

motorina0
Copy link
Member

This is a mirror of bitcoinjs/ecpair#8

junderw
junderw requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the private key tweak will actually return a Bip32 object. We should do the same we do for public and make a simple wrapper.

ts-src/bip32.ts Outdated Show resolved Hide resolved
@motorina0
Copy link
Member Author

Done. Extracted Bip32Signer parent class.

@junderw junderw merged commit e600f9f into bitcoinjs:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motorina0 @junderw