More integration tests

[dcousens]

These are acting as basic integration tests, as well as simplified examples that are easy for users to look at.

I think combined with different efforts in #272, this will make it quicker to get started for users.

[dcousens]

Added stealth address example, as per the unsystem wiki.
Only the single-key derivation is shown, but I'll add a dual-key before this is merged.

Might be worth looking to whether we should add an API to make this easy for people as well.

ping @caedesvvv , thoughts?

[coveralls]

Coverage increased (+0.0%) when pulling 6db700c on inttests into 27e69ba on master.

[weilu]

I like this approach to adding examples, because it prevents example code from rotting. I'm not sure we should use brand names for filenames as it might be seen as an endorsement. The helloblock example is there to illustrate p2sh spending and darkwallet stealth address. Not sure the brainwallet one is necessary as we already have message signing and verification under unit tests.

[dcousens]

I agree on the branding not being great. But the purpose was for feature
or example lookup. If you have a more obvious categorization technique,
I'm all for it.
On Oct 19, 2014 5:07 PM, "Wei Lu" notifications@github.com wrote:

I like this approach to adding examples, because it prevents example code
from rotting. I'm not sure we should use brand names for filenames as it
might be seen as an endorsement. The helloblock example is there to
illustrate p2sh spending and darkwallet stealth address. Not sure the
brainwallet one is necessary as we already have message signing and
verification under unit tests.

—
Reply to this email directly or view it on GitHub
#302 (comment)
.

[weilu]

helloblock.js -> p2sh.js
darkwallet.js -> stealth_address.js

[dcousens]

What about the README/generic examples?

On Sun, Oct 19, 2014 at 5:11 PM, Wei Lu notifications@github.com wrote:

helloblock.js -> p2sh.js
darkwallet.js -> stealth_address.js

—
Reply to this email directly or view it on GitHub
#302 (comment)
.

[weilu]

Either readme.js stays as is or rename to basic.js. And perhaps instead of code examples on readme we can create the following links to code:

How-To

• Derive an address from WIF
• Create a transaction
• Create an OP_RETURN transaction
• Create a P2SH address
• Integrate with a blockchain API & spend from P2SH
• Generate a stealth address

[dcousens]

Confirm the only thing blocking this was the renames?

[weilu]

that and if we want to get rid of brainwallet examples

[coveralls]

Coverage remained the same when pulling d9c716c on inttests into bd8a677 on master.

[dcousens]

@weilu should be good to go now.

[coveralls]

Coverage remained the same when pulling 7e7071b on inttests into bd8a677 on master.

[weilu]

@dcousens we might want to pin the links to examples to [sha of next release tag]~2 such that anyone with a release version of the code will have valid example references in the readme.

[dcousens]

The example links should remain valid unless someone updates the tests, no? Or did I miss what you were saying?

[weilu]

@dcousens yes. The situation I'm trying avoid is when someone install bitcoinjs-lib using npm, then they navigate to the README in their node_modules, following one of the links which points to master for examples, but the examples has been updated since the version they have. If we do what I described above, they'd end up with links pinned to a sha instead of master.