added a helloblock integration test for OP_RETURN #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Loop through the outputs and decode the message | ||
| var outputs = transaction.outputs | ||
| for (var j = outputs.length - 1; j >= 0; j--) { |
There was a problem hiding this comment.
Why are we looping at all if the transaction is expected to have the dataScript output at outputs[1]?
|
Happy to merge this once the nits have been worked out. |
dcousens
added a commit
that referenced
this pull request
Nov 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created an integration test that creates a random message in a OP_RETURN, propagates the transaction, and then checks to see that it went through and decodes properly.
It uses a random 5 character string for the test and you can see them here: http://testnet.coinsecrets.org/
Lemme know what you think! I've tried to adhere to the code style as close as possible.