Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crypto-js as a module from npm #57

Merged
merged 3 commits into from
Mar 11, 2014
Merged

Use crypto-js as a module from npm #57

merged 3 commits into from
Mar 11, 2014

Conversation

weilu
Copy link
Contributor

@weilu weilu commented Mar 8, 2014

Current crypto-js is partially ported from 2.0.0 and partially ported from 3.2.1(modified to use 2.0.0's interface). The npm crypto-js module is up-to-date. I hope to get the benefit of bug fixes & features from upstream by using the module. Also, applications that uses bitcoinjs-lib and cryto-js do not have to worry about two different implementations for the same set of cryto functions.

The downside of the module is that the source is uglified, so it isn't very debugging friendly.

@abrkn @kyledrake thoughts?

@kyledrake
Copy link
Contributor

This is great, and I think we should pull this in!

I'm getting a failing test due to global leaks on the Signing and Verifying test:

Error: global leaks detected: v, k

Not sure how to fix that one.

@weilu
Copy link
Contributor Author

weilu commented Mar 9, 2014

My bad. Only ran the tests with mocha test because I was working on individual test files. I didn't know that --check-leaks is turned off by default. Should have remembered to run npm test before pushing.

weilu added a commit that referenced this pull request Mar 11, 2014
Use crypto-js as a module from npm
@weilu weilu merged commit 9c15fa0 into master Mar 11, 2014
@weilu weilu deleted the upgrade-crypto-js branch March 14, 2014 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants