-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes for compatibility #11
Conversation
Signed-off-by: Brandon Black <brandonblack@bitgo.com>
0 and 1 are not valid private keys and some libraries will rightly reject them Signed-off-by: Brandon Black <brandonblack@bitgo.com>
You might want to take a look at the discussions below about removing cases with tweak = 0 in the tests in this PR: |
This test was put there to test that privateAdd actually uses scalars for the second position, and it's doing its job. |
Thanks @junderw and @landabaso!
Many forkcoins don't have a bech32 prefix. So, when using bitcoinjs libraries to support forkcoins, the |
Private key is scalar. What's the difference? Why would you allow 0 in privateKeyAdd, if it enables non-contributing behavior? |
for example, it was said curve25519 keys should not be validated, however, "zero" keys enabled some bad behavior: https://research.kudelskisecurity.com/2017/04/25/should-ecdh-keys-be-validated/ |
In the bitcoin secp256k1 library, the Whereas If we define The call signature for this function is The goal of the tiny-secp256k1 interface is to be in line with the secp256k1 library, but with a smaller interface than |
If the goal is to match btc libsecp api, that makes sense. |
Since the bech32 change is for non-Bitcoin assets, I will say no. And the privateAdd part has been explained so I will close this. Thanks for the PR. |
No description provided.