Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secp256k1 signature issue with messages > curve_order #106

Closed
landabaso opened this issue Jan 10, 2023 · 2 comments
Closed

Secp256k1 signature issue with messages > curve_order #106

landabaso opened this issue Jan 10, 2023 · 2 comments

Comments

@landabaso
Copy link
Contributor

A newer version of libsecp256k1 has fixed an issue with signing hashes when messages > curve_order. The signatures generated in this scenario were still valid, but they did not follow the spec and caused a mismatch with other secp256k1 implementations.

For more information on this issue, please see the following link:
bitcoin-core/secp256k1#1063

Two of the tests in test/fixtures/ecdsa.json are also affected.

To see this issue in action, I have prepared a small example that compares the results from tiny-secp256k1 and noble-secp256k1 (whose author is @paulmillr and it's also the same person that reported the issue in bitcoin-core). You can view the example at the following link:
https://runkit.com/landabaso/63bcfda6ab68f20008d424e6

@junderw
Copy link
Member

junderw commented Jan 10, 2023

I need to finish up #66 which will make it easier to bump versions.

@landabaso
Copy link
Contributor Author

Addressed in #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants