Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secp256k1-sys #119

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Bump secp256k1-sys #119

merged 2 commits into from
Jun 29, 2023

Conversation

junderw
Copy link
Member

@junderw junderw commented Jun 29, 2023

Should fix #118

@landabaso
Copy link
Contributor

landabaso commented Jun 29, 2023

Depending on the version of libsecp256k1 that is now being used, this fix might also address the issue discussed in this thread.

If that's the case, two of the ECDSA test fixtures might require adjustments:

    {
      "description": "Strange hash",
      "d": "0000000000000000000000000000000000000000000000000000000000000001",
      "m": "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
      "signature": "7cb38cc5712e9e11a767615f6080dbc111c9cdd613eb98999fd92a86bafd45407923ca1f4d03471d2866f776ef8a6d3cac099b427331aeb245aa9dafeddcf115",
      "recoveryId": 1
    },
    {
      "description": "Strange hash",
      "d": "fffffffffffffffffffffffffffffffebaaedce6af48a03bbfd25e8cd0364140",
      "m": "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
      "signature": "a7f83b5963eaf5332c633327cc967be8f4166d3f1e0b77f9761d8f4e42211e9a58aae31be1eb1e496923bbe8ca5e843cfb89f4d986d61d4edfd7d6fc3c9cf62c",
      "recoveryId": 0
    },

EDIT: Oups! You already did!

@junderw
Copy link
Member Author

junderw commented Jun 29, 2023

This is annoying.

eslint doesn't support type assertions for json import statements, so linting breaks.

But the workaround is Node only...

I tried using babel for eslint, but that didn't work...

@junderw junderw merged commit fb0287d into master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in signSchnorr output when using zero-filled Buffer versus no Buffer
2 participants