Topics: November update and new topics #286

harding · 2019-12-02T22:59:49Z

Topic updates
Four new topics (one per newsletter published in November)
A one-line bugfix and a one-line template tweak

jnewbery

Thanks for this @harding!

How long did it take you to prepare this PR? It took me a little under an hour to review.

_topics/en/transaction-bloom-filtering.md

_topics/en/cpfp.md

_topics/en/musig.md

_topics/en/schnorr-signatures.md

jonatack

Great stuff. A few comments follow.

jonatack · 2019-12-03T18:02:49Z

_topics/en/bech32.md

+    url: /en/newsletters/2019/11/27/#how-does-the-bech32-length-extension-mutation-weakness-work
+    date: 2019-11-27
+
+  - title: Impact of bech32 length-change mutablity on v1 segwit script length


s/mutablity/mutability

_topics/en/transaction-bloom-filtering.md

jonatack · 2019-12-03T18:33:44Z

_topics/en/transaction-bloom-filtering.md

+  mobile devices with limited bandwidth and so chose low false-positive
+  rates to minimize their bandwidth use.  This meant that they
+  essentially gave their list of addresses to any node they contacted.
+  Higher false positive rates may have partially mitigated this privacy


nit: above, "false positive" was hyphenated twice, then here and twice more without the hyphen

_topics/en/transaction-bloom-filtering.md

jonatack · 2019-12-03T18:35:59Z

_topics/en/transaction-bloom-filtering.md

+
+  Additionally, BIP37 filtering is performed independently for each
+  client by nodes and it's possible for filters to be created in a way
+  that requires nodes perform an extensive amount of CPU to filter each


s/perform/to perform/? and /CPU/CPU processing/?

jonatack · 2019-12-03T18:39:19Z

_topics/en/transaction-bloom-filtering.md

+  rates to minimize their bandwidth use.  This meant that they
+  essentially gave their list of addresses to any node they contacted.
+  Higher false positive rates may have partially mitigated this privacy
+  leak but false positives would be created at random from the set of


Careful of shifting verb tense, previously was in the past, here it is conditional, and in the following paragraph shifts again to present, then shifts in the last sentence "This resulted..." back to past tense.

jonatack · 2019-12-03T18:40:16Z

_topics/en/transaction-bloom-filtering.md

+  that requires nodes perform an extensive amount of CPU to filter each
+  block.  This resulted in a set of known DoS vectors against nodes.
+
+  Although in practice, BIP37 allowed clients to use a fairly small


s/practice,/practice/ (remove the comma, I believe, or restructure)

harding · 2019-12-04T17:49:29Z

Forced pushed with edits, including an almost complete rewrite of the confusing paragraph from the CPFP topic. Thanks @jnewbery and @jonatack for the reviews!

bitschmidty

tACK

Reviewed new topics (content, linking)
Reviewed 'updates for November' text
Tested 'updates for November' links
make production for site successful

_topics/en/cpfp.md

_topics/en/musig.md

_topics/en/transaction-bloom-filtering.md

jnewbery · 2019-12-09T22:44:31Z

_topics/en/transaction-bloom-filtering.md

+  It was expected that privacy-focused users could mitigate this privacy
+  loss by setting a higher false positive rate, but research suggests
+  that the rate needs to be quite high in order to provide plausible
+  deniability.  The problem is a consequence of the different types of


Is there a source we can link to that explains this? Everything from "The problem is a consequence of..." is perhaps a bit too low-level for a summary.

Yeah, Jonas Nick's article already linked in the see also section. https://jonasnick.github.io/blog/2015/02/12/privacy-in-bitcoinj/

I still think that this topic summary would be snappier with everything from "The problem is a consequence of..." onward removed. Do you think it needs to stay?

_topics/en/transaction-bloom-filtering.md

_topics/en/cpfp.md

jnewbery

Thanks @harding . You've resolved all my previous review comments. I have a couple more for you :)

jnewbery · 2019-12-16T20:55:12Z

ping @harding . I think this is ready for merge after the last round of review comments from bitschmidty and me are addressed.

harding · 2019-12-16T20:58:55Z

Sorry, I haven't forgotten, just juggling several other things. I expect to get back to this Thursday.

jnewbery · 2019-12-16T21:27:13Z

No rush. Just wanted to make sure you weren't waiting on something from me.

jnewbery · 2019-12-19T20:53:09Z

_topics/en/cpfp.md

+    url: /en/newsletters/2019/06/19/#lnd-3140
+    date: 2019-06-19
+
+  - title: "Refactory preparing for ancestor relay"


s/Refactory/Refactor/

jnewbery · 2019-12-19T20:59:52Z

_topics/en/transaction-bloom-filtering.md

+  It was expected that privacy-focused users could mitigate this privacy
+  loss by setting a higher false positive rate, but research suggests
+  that the rate needs to be quite high in order to provide plausible
+  deniability.  The problem is a consequence of the different types of


I still think that this topic summary would be snappier with everything from "The problem is a consequence of..." onward removed. Do you think it needs to stay?

…ilters

jnewbery · 2019-12-19T22:24:39Z

ACK 9d2a972

Thanks @harding !

harding added 2 commits December 2, 2019 17:09

Contrib: fix directory for new topics

ef84a0a

Topic indexes: add anchors to topic categories page

54513d6

jnewbery reviewed Dec 3, 2019

View reviewed changes

jonatack reviewed Dec 3, 2019

View reviewed changes

harding force-pushed the 2019-12-topic-update branch from bb2573e to b1bb07e Compare December 4, 2019 17:48

bitschmidty reviewed Dec 9, 2019

View reviewed changes

jnewbery reviewed Dec 9, 2019

View reviewed changes

jnewbery added the topics Topics indexes label Dec 10, 2019

harding force-pushed the 2019-12-topic-update branch from b1bb07e to 7c2e892 Compare December 19, 2019 20:02

jnewbery reviewed Dec 19, 2019

View reviewed changes

harding added 2 commits December 19, 2019 16:16

Topics: new topics for CPFP, musig, coin selection, and BIP37 bloom f…

76dc68a

…ilters

Topics: updates for November

9d2a972

harding force-pushed the 2019-12-topic-update branch from 7c2e892 to 9d2a972 Compare December 19, 2019 21:16

jnewbery merged commit 89ca6ee into bitcoinops:master Dec 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topics: November update and new topics #286

Topics: November update and new topics #286

harding commented Dec 2, 2019

jnewbery left a comment

jonatack left a comment •

edited

Loading

jonatack Dec 3, 2019

jonatack Dec 3, 2019

jonatack Dec 3, 2019

jonatack Dec 3, 2019

jonatack Dec 3, 2019 •

edited

Loading

harding commented Dec 4, 2019

bitschmidty left a comment

jnewbery Dec 9, 2019

harding Dec 10, 2019

jnewbery Dec 19, 2019

jnewbery left a comment

jnewbery commented Dec 16, 2019

harding commented Dec 16, 2019

jnewbery commented Dec 16, 2019

jnewbery Dec 19, 2019

jnewbery Dec 19, 2019

jnewbery commented Dec 19, 2019

Topics: November update and new topics #286

Topics: November update and new topics #286

Conversation

harding commented Dec 2, 2019

jnewbery left a comment

Choose a reason for hiding this comment

jonatack left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonatack Dec 3, 2019 • edited Loading

Choose a reason for hiding this comment

harding commented Dec 4, 2019

bitschmidty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnewbery left a comment

Choose a reason for hiding this comment

jnewbery commented Dec 16, 2019

harding commented Dec 16, 2019

jnewbery commented Dec 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnewbery commented Dec 19, 2019

jonatack left a comment •

edited

Loading

jonatack Dec 3, 2019 •

edited

Loading