Stop high level commander instead of disable #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receiving low level set points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the high level commander when receiving low level set points, for instance from an external script.
The new functionality is to stop the high level commander instead of disabling it. The difference is that when the high level commander is stopped, it will still send null set points to the system, while it is quiet when disabled.
This makes a difference if a user sends in some low level set points for a while, and then whants to go back to the high level commander by using the meta message to relax the set point priority. In the current implementation, the user must first re-start the high level commander and then relax the priority. With this PR, the high level commander will still run and produce null set points which means that the user can go back to the previous state by only relaxing priority.