Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circling square demo with colors #385

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Conversation

hmllr
Copy link
Contributor

@hmllr hmllr commented Mar 8, 2023

First turn off LEDs, then take off as first thing in swarm cmd to avoid delays

First turn off LEDs, then take off as first thing in swarm cmd to avoid delays
@knmcguire
Copy link
Member

There is some checks that failed with the script. You can check out the CI of what went wrong

Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments above

@krichardsson
Copy link
Contributor

I might be a bit late in the game here, but I have a couple of improvements that I would like to suggest:

  • Use pi (in math or numpy) instead of 3.14
  • The copyright year in the header is a bit old :-)

change 3.14 to pi and copyrightyear
@krichardsson krichardsson merged commit 9789d1a into bitcraze:master Mar 23, 2023
@krichardsson
Copy link
Contributor

Nice!

@knmcguire knmcguire added this to the next release milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants